chore: remove expired and soon-to-expire certificates from test suite#1728
Open
chore: remove expired and soon-to-expire certificates from test suite#1728
Conversation
The tests associated with such certificates are also deleted accordingly. Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
fix/noid/renew-test-certs
branch
from
872a7eb to
c0087de
Compare
Collaborator
Can we regenerate certificates, cause with just test removal we just loosing coverage for the And I assume (I might be wrong) that the |
Collaborator
Author
|
That would be ideal, but so far, I haven't been able to figure out how to regenerate them. They were generated from #258 and I don't know which private keys/CAs they used back then (they might not be in the repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests associated with such certificates are also deleted accordingly, as they are now failing due to the certificates expiring.